Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: Expose apps enable setting at General > Apps #12196

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Improve: Expose apps enable setting at General > Apps #12196

merged 2 commits into from
Sep 28, 2018

Conversation

rodrigok
Copy link
Member

No description provided.

@rodrigok rodrigok added this to the 0.70.0 milestone Sep 27, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12196 September 27, 2018 22:32 Inactive
graywolf336
graywolf336 previously approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would like to see settings underneath the Apps not and the general settings page. That way everything related to the Apps is all in one place. But for now, this will suffice.

@sampaiodiego sampaiodiego merged commit 528e0f5 into develop Sep 28, 2018
@sampaiodiego sampaiodiego deleted the improve/apps-enable-setting branch September 28, 2018 01:25
This was referenced Sep 28, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@graywolf336 graywolf336 graywolf336 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigok @graywolf336 @sampaiodiego @engelgabriel